-
Notifications
You must be signed in to change notification settings - Fork 11
Feature/condition return #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ehuelsmann
merged 4 commits into
perl-workflow:master
from
oliwel:feature/condition-return
Aug 22, 2023
Merged
Feature/condition return #221
ehuelsmann
merged 4 commits into
perl-workflow:master
from
oliwel:feature/condition-return
Aug 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions are designed to return a boolean value and not any kind of typed information. Those classes violate this interface contract and are therefore removed.
A strict type checking on the return value of the evaluate call will prevent accidential decission errors due to bugs in the condition classes. The interface contract for conditions now enforces that an instance of Workflow::Condition::IsTrue/::IsFalse is returned. Any other value will cause the workflow to croak with an error
ehuelsmann
reviewed
Aug 6, 2023
ehuelsmann
reviewed
Aug 6, 2023
ehuelsmann
reviewed
Aug 6, 2023
ehuelsmann
reviewed
Aug 6, 2023
ehuelsmann
reviewed
Aug 21, 2023
ehuelsmann
reviewed
Aug 21, 2023
ehuelsmann
reviewed
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce conditions to return a class object on evaluate instead of judging on perlish boolean values.
Also removes the GreedyOr and CheckReturn condition as those violate the "boolean return" interface contract.
Type of change
Please delete options that are not relevant.
Checklist:
You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)