some tweaks #1
Closed
some tweaks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-fritsche
reviewed
May 20, 2020
| // Skip unitialized properties on $data | ||
| $this->catchUninitializedPropertyException($e); | ||
| } | ||
| $form->setData($this->getPropertyValue($data, $propertyPath)); |
There was a problem hiding this comment.
This sets null for properties that are not-nullable typed.
There was a problem hiding this comment.
I am afraid I do not understand what you mean. If we didn't have this call at all, the value would already be null. So what would be the difference here? Do you have an example test case which we could add that would show the difference?
ph-fritsche
reviewed
May 20, 2020
Comment on lines
-375
to
+374
| class NotSynchronizedForm extends SubmittedForm | ||
| class NotSynchronizedForm extends Form |
There was a problem hiding this comment.
The check is implemented as
if (null !== $propertyPath && $config->getMapped() && $form->isSubmitted() && $form->isSynchronized() && !$form->isDisabled()) {If the form is not submitted, the test provides a false negative for $form->isSynchronized() because it is never called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.