fix: zoom editor fonts only and live preview switch issues #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore Editor-Only Font Zoom Functionality
Context: In the initial version of Phoenix, the font zoom feature was limited to the editor, similar to the behavior observed in Brackets. However, when system-wide zoom capabilities were lacking, Phoenix expanded the font zoom to include menus and other UI elements as a temporary measure.
Issue: Although native system-wide zoom was later successfully integrated into the Tauri layer, the temporary extension of font zoom to all UI elements was never reverted. This led to unnecessary zooming of UI components that should not typically scale with the editor font settings.
Solution: This pull request aims to revert the font zoom functionality so that it exclusively applies to the editor's font. This change reinstates the original, more focused behavior and utilizes the native system-wide zoom capabilities for broader UI scaling needs.
Fixes: https://github.com/orgs/phcode-dev/discussions/1798
Also fix live preview switch issues
When a related js file is open in the editor, and clicking on a text box in the live preview focuses the active editor, never being able to type text in the text field. That breaks dev workflows.