Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jasalt
Copy link
Member

@jasalt jasalt commented Sep 1, 2025

Quick experiment for #123 & #110. Seems to work mostly with some rough edges.

Screenshot_20250901_055404

Modifies ApiSearchGenerator.php ran with the existing composer build action to also index Markdown files from content/documentation/ and search.js to list the entries with separate template per match type based on new "type" property added in search index results with values "documentation" or "api".

Does some filtering on the markdown content during indexing which probably needs tuning to get best result, also the search.js weight settings might need tuning. Claude also though to change search.js boolean logic from "AND" to "OR" for more flexible search results, but I did not evaluate that.

Tests were modified to get them passing and some refactoring might be useful, coverage for the documentation search entries is not at same level as for API entries but not zero.

If combining search indexing logic in single file this way, should the ApiSearchGenerator.php be renamed to just SearchGenerator.php? Other thoughts?

@jasalt jasalt marked this pull request as ready for review September 1, 2025 03:51
@Chemaclass Chemaclass added the enhancement New feature or request label Sep 1, 2025
Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Chemaclass Chemaclass merged commit 176d5ae into phel-lang:master Sep 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants