fix: symfony/console:7.3 setCode call and php8.4 deprecation warnings #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@marko-krueger, thanks very much for raising this with a PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 73.25% 73.25%
Complexity 56 56
=========================================
Files 2 2
Lines 172 172
=========================================
Hits 126 126
Misses 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisminett
previously approved these changes
Jun 20, 2025
chrisminett
reviewed
Jun 20, 2025
chrisminett
approved these changes
Jun 26, 2025
Member
|
I squashed and merged this directly, as it couldn't be merged with unsigned commits. Thanks for all your work on this @marko-krueger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent::setCode()in Symfony 7.3 has changed, it requires now a callable