This repository was archived by the owner on Apr 30, 2025. It is now read-only.
DRAFT: GUILD-625: Changes required to support multiple topic subscrip…#136
Open
eduardopoleoflipp wants to merge 1 commit into
Open
DRAFT: GUILD-625: Changes required to support multiple topic subscrip…#136eduardopoleoflipp wants to merge 1 commit into
eduardopoleoflipp wants to merge 1 commit into
Conversation
…tions per listener
|
Code Climate has analyzed commit 0badae9 and detected 0 issues on this pull request. View more on Code Climate. |
dorner
suggested changes
May 14, 2021
dorner
left a comment
Contributor
There was a problem hiding this comment.
Added some comments. Also, are there specs we can improve to cover this case?
| DELIVERY_OPTS = %w[batch message inline_batch].freeze | ||
|
|
||
| attr_reader :group_id, :topic, :id | ||
| attr_reader :group_id, :topics, :id |
Contributor
There was a problem hiding this comment.
For backwards compatibility, let's keep both :topic and :topics and deprecate :topic. attr_reader is public so we have no idea if someone would be accessing this for some reason.
| @consumer = create_kafka_consumer | ||
| @consumer.subscribe(topic, **@subscribe_opts) | ||
|
|
||
| # ruby-kafka does not provide an api to subscribe a group of particular topics |
Contributor
There was a problem hiding this comment.
There technically is one, although it would mean turning topic into a regex that includes all of the topics, e.g.
topic_regex = Regexp.new("^#{topics.join('|')}$")
@consumer.subscribe(topic_regex, **@subscribe_opts)...but I don't think that's any cleaner at all. :p Maybe just take the comment out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions per listener