Simplify modular threads #1874
Merged
Simplify modular threads #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withinboredom
approved these changes
Sep 13, 2025
dunglas
added a commit
that referenced
this pull request
Sep 15, 2025
* Simplify * remove unused variable * log thread index
dunglas
added a commit
that referenced
this pull request
Sep 15, 2025
* Simplify * remove unused variable * log thread index
dunglas
added a commit
that referenced
this pull request
Sep 15, 2025
* Simplify * remove unused variable * log thread index
dunglas
added a commit
that referenced
this pull request
Sep 18, 2025
* create a simple thread framework Signed-off-by: Robert Landers <[email protected]> * add tests Signed-off-by: Robert Landers <[email protected]> * fix comment Signed-off-by: Robert Landers <[email protected]> * remove mention of an old function that no longer exists Signed-off-by: Robert Landers <[email protected]> * simplify providing a request Signed-off-by: Robert Landers <[email protected]> * satisfy linter Signed-off-by: Robert Landers <[email protected]> * add error handling and handle shutdowns Signed-off-by: Robert Landers <[email protected]> * add tests Signed-off-by: Robert Landers <[email protected]> * pipes are tied to workers, not threads Signed-off-by: Robert Landers <[email protected]> * fix test Signed-off-by: Robert Landers <[email protected]> * add a way to detect when a request is completed Signed-off-by: Robert Landers <[email protected]> * we never shutdown workers or remove them, so we do not need this Signed-off-by: Robert Landers <[email protected]> * add more comments Signed-off-by: Robert Landers <[email protected]> * Simplify modular threads (#1874) * Simplify * remove unused variable * log thread index * feat: allow passing parameters to the PHP callback and accessing its return value (#1881) * fix formatting Signed-off-by: Robert Landers <[email protected]> * fix test compilation Signed-off-by: Robert Landers <[email protected]> * fix segfaults Signed-off-by: Robert Landers <[email protected]> * Update frankenphp.c Co-authored-by: Kévin Dunglas <[email protected]> --------- Signed-off-by: Robert Landers <[email protected]> Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT @withinboredom?