Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix GH-10152: Custom properties of Date's child classes are not serialised #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix GH-10152: Custom properties of Date's child classes are not serialised #10446

merged 1 commit into from
Jan 31, 2023

Conversation

derickr
Copy link
Member

@derickr derickr commented Jan 25, 2023

No description provided.

@derickr derickr requested a review from cmb69 January 25, 2023 17:41
@derickr derickr self-assigned this Jan 25, 2023
@cmb69
Copy link
Member

cmb69 commented Jan 26, 2023

It seems that ext/date/tests/bug53437_var3.phpt would need to be updated, too. I'm generally very cautious when modifying regression tests for reported bugs, though, but haven't looked closer into this bug yet.

@derickr
Copy link
Member Author

derickr commented Jan 26, 2023

The bug 53437 test cases where already wrong, as they were not updated when we cleaned up the classes' properties in PR #8459.

cmb69
cmb69 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

I'm not really happy with the *_is_internal_property() functions (especially for DateInterval), but a more performant solution would likely be way harder to understand, and this doesn't look like a critical code path anyway.

@derickr derickr force-pushed the GH-10152-serialise-datetime branch from 6ed8f85 to 045930e Compare January 31, 2023 12:50
@derickr derickr force-pushed the GH-10152-serialise-datetime branch from 045930e to 85fbc6e Compare January 31, 2023 12:53
@derickr derickr merged commit 322425e into php:PHP-8.2 Jan 31, 2023
@derickr derickr deleted the GH-10152-serialise-datetime branch January 31, 2023 12:56
@derickr derickr mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

@derickr derickr

Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derickr @cmb69 @OskarStark