Fix GH-13097: Anonymous class reference in trigger_error / thrown Exception #13153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 16, 2024
Comment on lines
1131
to
1132
| // TODO Change to void | ||
| RETURN_TRUE; |
There was a problem hiding this comment.
Random aside: the stub for this function is bool instead of true.
| php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%" PRIu32 "</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, ZSTR_VAL(message), ZSTR_VAL(error_filename), error_lineno, STR_PRINT(append_string)); | ||
| zval tmp; | ||
| ZVAL_STR(&tmp, message); | ||
| php_printf_unchecked("%s<br />\n<b>%s</b>: %Z in <b>%s</b> on line <b>%" PRIu32 "</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, &tmp, ZSTR_VAL(error_filename), error_lineno, STR_PRINT(append_string)); |
There was a problem hiding this comment.
Does it possibly makes sense to create a new custom format for master %S that takes a zend_string?
This was referenced Jan 16, 2024
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 22, 2024
… classes on PHP >= 8.3.3 (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] Fix parsing messages that contain anonymous classes on PHP >= 8.3.3 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follows php/php-src#13153 and #40065 Commits ------- 699f400 [ErrorHandler] Fix parsing messages that contain anonymous classes on PHP >= 8.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does fix #13097
But does not fix #13142 (see #13142 (comment))