Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn about invalid strings in arithmetic #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hikari-no-yume wants to merge 14 commits into from
Closed

Warn about invalid strings in arithmetic #1718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
63e214c
Warn on non-/bad numeric strings in arithmetic
hikari-no-yume Jan 6, 2016
c21f088
Update tests
hikari-no-yume Jan 7, 2016
5ac4a0c
Use is_numeric_string_ex for zval_get_long etc.
hikari-no-yume Jan 26, 2016
84d6632
Update tests
hikari-no-yume Jan 26, 2016
e05b0cc
Make _zval_get_long_func_noisy function for inlining
hikari-no-yume Feb 5, 2016
f9dc354
Disable compile-time evaluation for numeric string errors
hikari-no-yume Feb 13, 2016
a6403b7
Do not convert error-causing numeric strings ahead-of-time
hikari-no-yume Feb 13, 2016
30ee954
fixup
hikari-no-yume Feb 14, 2016
d94c088
Disable optimiser evaluation for numeric string errors
hikari-no-yume Feb 14, 2016
c72e92f
Add test for scientific notation in integer operations
hikari-no-yume Jan 26, 2016
bd5f04e
Add test for numeric string errors
hikari-no-yume Feb 13, 2016
6dadb1b
Add test for numeric string errors in assignment
hikari-no-yume Feb 14, 2016
6caf1d4
Fixes
hikari-no-yume Mar 20, 2016
e05d3b6
UPGRADING and NEWS
hikari-no-yume Mar 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests
  • Loading branch information
@hikari-no-yume
hikari-no-yume committed Mar 30, 2016
commit 84d66321a57e579759109650c8bb7e3d5002854a
16 changes: 8 additions & 8 deletions ext/standard/tests/general_functions/gettype_settype_variation2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ string(7) "integer"
-- Iteration 18 --
string(6) "string"
bool(true)
int(1)
int(100)
string(7) "integer"
-- Iteration 19 --
string(6) "string"
Expand All @@ -297,7 +297,7 @@ string(7) "integer"
-- Iteration 21 --
string(6) "string"
bool(true)
int(-1)
int(0)
string(7) "integer"
-- Iteration 22 --
string(6) "string"
Expand All @@ -312,7 +312,7 @@ string(7) "integer"
-- Iteration 24 --
string(6) "string"
bool(true)
int(1)
int(100)
string(7) "integer"
-- Iteration 25 --
string(6) "string"
Expand All @@ -327,7 +327,7 @@ string(7) "integer"
-- Iteration 27 --
string(6) "string"
bool(true)
int(-1)
int(0)
string(7) "integer"
-- Iteration 28 --
string(6) "string"
Expand Down Expand Up @@ -687,7 +687,7 @@ string(7) "integer"
-- Iteration 18 --
string(6) "string"
bool(true)
int(1)
int(100)
string(7) "integer"
-- Iteration 19 --
string(6) "string"
Expand All @@ -702,7 +702,7 @@ string(7) "integer"
-- Iteration 21 --
string(6) "string"
bool(true)
int(-1)
int(0)
string(7) "integer"
-- Iteration 22 --
string(6) "string"
Expand All @@ -717,7 +717,7 @@ string(7) "integer"
-- Iteration 24 --
string(6) "string"
bool(true)
int(1)
int(100)
string(7) "integer"
-- Iteration 25 --
string(6) "string"
Expand All @@ -732,7 +732,7 @@ string(7) "integer"
-- Iteration 27 --
string(6) "string"
bool(true)
int(-1)
int(0)
string(7) "integer"
-- Iteration 28 --
string(6) "string"
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/math/decbin_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ string(2) "11"
string(7) "1011111"
string(4) "1010"
string(12) "111101101110"
string(2) "11"
string(12) "111101101110"
string(6) "100111"
string(1) "0"
string(1) "1"
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/math/dechex_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ string(1) "3"
string(2) "5f"
string(1) "a"
string(3) "f6e"
string(1) "3"
string(3) "f6e"
string(2) "27"
string(1) "0"
string(1) "1"
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/math/decoct_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ string(1) "3"
string(3) "137"
string(2) "12"
string(4) "7556"
string(1) "3"
string(4) "7556"
string(2) "47"
string(1) "0"
string(1) "1"
Expand Down
20 changes: 10 additions & 10 deletions tests/lang/operators/bitwiseShiftLeft_variationStr_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,17 +226,17 @@ int(984)
--- testing: '123abc' << 'a5.9' ---
int(123)
--- testing: '123e5' << '0' ---
int(123)
int(12300000)
--- testing: '123e5' << '65' ---
int(0)
--- testing: '123e5' << '-44' ---
Exception: Bit shift by negative number
--- testing: '123e5' << '1.2' ---
int(246)
int(24600000)
--- testing: '123e5' << '-7.7' ---
Exception: Bit shift by negative number
--- testing: '123e5' << 'abc' ---
int(123)
int(12300000)
--- testing: '123e5' << '123abc' ---
int(0)
--- testing: '123e5' << '123e5' ---
Expand All @@ -250,21 +250,21 @@ int(0)
--- testing: '123e5' << '123abc ' ---
int(0)
--- testing: '123e5' << '3.4a' ---
int(984)
int(98400000)
--- testing: '123e5' << 'a5.9' ---
int(123)
int(12300000)
--- testing: '123e5xyz' << '0' ---
int(123)
int(12300000)
--- testing: '123e5xyz' << '65' ---
int(0)
--- testing: '123e5xyz' << '-44' ---
Exception: Bit shift by negative number
--- testing: '123e5xyz' << '1.2' ---
int(246)
int(24600000)
--- testing: '123e5xyz' << '-7.7' ---
Exception: Bit shift by negative number
--- testing: '123e5xyz' << 'abc' ---
int(123)
int(12300000)
--- testing: '123e5xyz' << '123abc' ---
int(0)
--- testing: '123e5xyz' << '123e5' ---
Expand All @@ -278,9 +278,9 @@ int(0)
--- testing: '123e5xyz' << '123abc ' ---
int(0)
--- testing: '123e5xyz' << '3.4a' ---
int(984)
int(98400000)
--- testing: '123e5xyz' << 'a5.9' ---
int(123)
int(12300000)
--- testing: ' 123abc' << '0' ---
int(123)
--- testing: ' 123abc' << '65' ---
Expand Down
20 changes: 10 additions & 10 deletions tests/lang/operators/bitwiseShiftRight_variationStr.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,17 +222,17 @@ int(15)
--- testing: '123abc' >> 'a5.9' ---
int(123)
--- testing: '123e5' >> '0' ---
int(123)
int(12300000)
--- testing: '123e5' >> '65' ---
int(0)
--- testing: '123e5' >> '-44' ---
Exception: Bit shift by negative number
--- testing: '123e5' >> '1.2' ---
int(61)
int(6150000)
--- testing: '123e5' >> '-7.7' ---
Exception: Bit shift by negative number
--- testing: '123e5' >> 'abc' ---
int(123)
int(12300000)
--- testing: '123e5' >> '123abc' ---
int(0)
--- testing: '123e5' >> '123e5' ---
Expand All @@ -246,21 +246,21 @@ int(0)
--- testing: '123e5' >> '123abc ' ---
int(0)
--- testing: '123e5' >> '3.4a' ---
int(15)
int(1537500)
--- testing: '123e5' >> 'a5.9' ---
int(123)
int(12300000)
--- testing: '123e5xyz' >> '0' ---
int(123)
int(12300000)
--- testing: '123e5xyz' >> '65' ---
int(0)
--- testing: '123e5xyz' >> '-44' ---
Exception: Bit shift by negative number
--- testing: '123e5xyz' >> '1.2' ---
int(61)
int(6150000)
--- testing: '123e5xyz' >> '-7.7' ---
Exception: Bit shift by negative number
--- testing: '123e5xyz' >> 'abc' ---
int(123)
int(12300000)
--- testing: '123e5xyz' >> '123abc' ---
int(0)
--- testing: '123e5xyz' >> '123e5' ---
Expand All @@ -274,9 +274,9 @@ int(0)
--- testing: '123e5xyz' >> '123abc ' ---
int(0)
--- testing: '123e5xyz' >> '3.4a' ---
int(15)
int(1537500)
--- testing: '123e5xyz' >> 'a5.9' ---
int(123)
int(12300000)
--- testing: ' 123abc' >> '0' ---
int(123)
--- testing: ' 123abc' >> '65' ---
Expand Down
28 changes: 14 additions & 14 deletions tests/lang/operators/modulus_variationStr.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ Exception: Modulo by zero
--- testing: '123abc' % '123abc' ---
int(0)
--- testing: '123abc' % '123e5' ---
int(0)
int(123)
--- testing: '123abc' % '123e5xyz' ---
int(0)
int(123)
--- testing: '123abc' % ' 123abc' ---
int(0)
--- testing: '123abc' % '123 abc' ---
Expand All @@ -224,13 +224,13 @@ Exception: Modulo by zero
--- testing: '123e5' % '0' ---
Exception: Modulo by zero
--- testing: '123e5' % '65' ---
int(58)
int(50)
--- testing: '123e5' % '-44' ---
int(35)
int(20)
--- testing: '123e5' % '1.2' ---
int(0)
--- testing: '123e5' % '-7.7' ---
int(4)
int(6)
--- testing: '123e5' % 'abc' ---
Exception: Modulo by zero
--- testing: '123e5' % '123abc' ---
Expand All @@ -252,13 +252,13 @@ Exception: Modulo by zero
--- testing: '123e5xyz' % '0' ---
Exception: Modulo by zero
--- testing: '123e5xyz' % '65' ---
int(58)
int(50)
--- testing: '123e5xyz' % '-44' ---
int(35)
int(20)
--- testing: '123e5xyz' % '1.2' ---
int(0)
--- testing: '123e5xyz' % '-7.7' ---
int(4)
int(6)
--- testing: '123e5xyz' % 'abc' ---
Exception: Modulo by zero
--- testing: '123e5xyz' % '123abc' ---
Expand Down Expand Up @@ -292,9 +292,9 @@ Exception: Modulo by zero
--- testing: ' 123abc' % '123abc' ---
int(0)
--- testing: ' 123abc' % '123e5' ---
int(0)
int(123)
--- testing: ' 123abc' % '123e5xyz' ---
int(0)
int(123)
--- testing: ' 123abc' % ' 123abc' ---
int(0)
--- testing: ' 123abc' % '123 abc' ---
Expand All @@ -320,9 +320,9 @@ Exception: Modulo by zero
--- testing: '123 abc' % '123abc' ---
int(0)
--- testing: '123 abc' % '123e5' ---
int(0)
int(123)
--- testing: '123 abc' % '123e5xyz' ---
int(0)
int(123)
--- testing: '123 abc' % ' 123abc' ---
int(0)
--- testing: '123 abc' % '123 abc' ---
Expand All @@ -348,9 +348,9 @@ Exception: Modulo by zero
--- testing: '123abc ' % '123abc' ---
int(0)
--- testing: '123abc ' % '123e5' ---
int(0)
int(123)
--- testing: '123abc ' % '123e5xyz' ---
int(0)
int(123)
--- testing: '123abc ' % ' 123abc' ---
int(0)
--- testing: '123abc ' % '123 abc' ---
Expand Down