Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ext/date: Remove implicit bool type coercions in tests #18891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −32
Open

ext/date: Remove implicit bool type coercions in tests #18891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ext/date/tests/bug33536.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ Bug #33456 (strtotime defaults to now even on non time string)
<?php
date_default_timezone_set("GMT");
var_dump(strtotime("monkey"));
print date("Y-m-d", strtotime("monkey")) ."\n";
print date("Y-m-d", false) ."\n";
?>
--EXPECT--
bool(false)
1970-01-01
1970-01-01
4 changes: 2 additions & 2 deletions ext/date/tests/bug44780.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Bug #44780 (some time zone offsets not recognized by timezone_name_from_abbr)
--FILE--
<?php
var_dump( timezone_name_from_abbr("", 5.5*3600, false) );
var_dump( timezone_name_from_abbr("", 28800, false) );
var_dump( timezone_name_from_abbr("", 5.5*3600, 0) );
var_dump( timezone_name_from_abbr("", 28800, 0) );
?>
--EXPECT--
string(12) "Asia/Kolkata"
Expand Down
57 changes: 31 additions & 26 deletions ext/date/tests/date_sun_info_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,43 @@ edgarsandi - <[email protected]>
--FILE--
<?php
date_default_timezone_set('America/Sao_Paulo');
$sun_info = date_sun_info(strtotime("2015-01-12 00:00:00 UTC"), 89.00, 1.00);
foreach ($sun_info as $key => $elem ) {
echo "$key: " . date("H:i:s", $elem) . "\n";

function print_sun_info(string $date) {
echo $date, "\n";
$sun_info = date_sun_info(strtotime($date), 89.00, 1.00);
foreach ($sun_info as $key => $elem ) {
echo "$key: " . match ($elem) {
true => 'always',
false => 'never',
default => date("H:i:s", $elem),
} . "\n";
}
}

print_sun_info("2015-01-12 00:00:00 UTC");
echo "\n";
print_sun_info("2015-09-12 00:00:00 UTC");

$sun_info = date_sun_info(strtotime("2015-09-12 00:00:00 UTC"), 89.00, 1.00);
foreach ($sun_info as $key => $elem ) {
echo "$key: " . date("H:i:s", $elem) . "\n";
}

echo "Done\n";
?>
--EXPECT--
sunrise: 21:00:00
sunset: 21:00:00
2015-01-12 00:00:00 UTC
sunrise: never
sunset: never
transit: 10:03:48
civil_twilight_begin: 21:00:00
civil_twilight_end: 21:00:00
nautical_twilight_begin: 21:00:00
nautical_twilight_end: 21:00:00
astronomical_twilight_begin: 21:00:00
astronomical_twilight_end: 21:00:00
civil_twilight_begin: never
civil_twilight_end: never
nautical_twilight_begin: never
nautical_twilight_end: never
astronomical_twilight_begin: never
astronomical_twilight_end: never

sunrise: 21:00:01
sunset: 21:00:01
2015-09-12 00:00:00 UTC
sunrise: always
sunset: always
transit: 08:52:44
civil_twilight_begin: 21:00:01
civil_twilight_end: 21:00:01
nautical_twilight_begin: 21:00:01
nautical_twilight_end: 21:00:01
astronomical_twilight_begin: 21:00:01
astronomical_twilight_end: 21:00:01
Done
civil_twilight_begin: always
civil_twilight_end: always
nautical_twilight_begin: always
nautical_twilight_end: always
astronomical_twilight_begin: always
astronomical_twilight_end: always