Further cleanup of DOM mapping APIs #18894
Open
+136
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have to pack the bools, and the cached index would better be a zend_long so we don't get implicit narrowing.
…ctive at the same time
Splits the purpose of the baseobj_zv: now no longer either is an array or an object. Stores the hash table pointer directly, if used.
Comment on lines
+34
to
+42
| union { | ||
| xmlHashTable *ht; | ||
| HashTable *array; | ||
| struct { | ||
| xmlChar *local; | ||
| zend_string *local_lower; | ||
| xmlChar *ns; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
The indentation here is using a tab instead of spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits