Removed ZEND_IS_XDIGIT()
#18926
Merged
Removed ZEND_IS_XDIGIT()
#18926
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
This is probably a remnant of https://wiki.php.net/rfc/remove_hex_support_in_numeric_strings
|
It appears to have been around since 2006. ff9d0fc#diff-8e51ab7f9c143d49351a9e71d73cdab8b84ef38d3a456194c2ee741d8c39703dR79 |
Right, but the support of Hexadecimal numeric strings was removed in 7.0, and the commit references an optimization for that behaviour. :) |
|
Ah! I see, I misunderstood. |
|
Third party extensions may use this (e.g. protobuf), why not fix the macro instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro cannot correctly determine whether a string is a valid hexadecimal unless used together with
ZEND_IS_DIGIT().In practice, it is not used anywhere within php-src, and its name does not reflect its actual behavior, so I propose removing it.