Switch to windows-2022 in CI #18927
Merged
Switch to windows-2022 in CI #18927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-2019 runner will be dropped by GitHub on 2025-06-30.
869008c to
2657fac
Compare
cmb69
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Thank you @shivammathur!
I'm generally fine with the PR, but if you prefer to rewrite find-vs-toolset.bat in Powershell, I'm certainly not against that.
Regarding the test failures: almost certainly due to stack unwinding on Windows 2022; @dstogov fixed that with ccc6c0f for PHP-8.4. I don't think that we can backport that, so it might be best to mark the test as XFAIL.
|
@cmb69 I think we can keep it in batch for consistency. |
Yeah, sure! (Actually, I'm neither happy with complex batch scripts, nor with Powershell scripts.) |
shivammathur
added a commit
to shivammathur/php-src
that referenced
this pull request
Jun 24, 2025
This is a continuation of phpGH-18927 to fix CI for windows-2022
shivammathur
added a commit
to shivammathur/php-src
that referenced
this pull request
Jun 24, 2025
This is a continuation of phpGH-18927 to fix CI for windows-2022
shivammathur
added a commit
to shivammathur/php-src
that referenced
this pull request
Jun 24, 2025
This is a continuation of phpGH-18927 to fix CI for windows-2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-2019 runner will be dropped by GitHub on 2025-06-30.
Ref: actions/runner-images#12045