Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support every argument syntax for clone() #18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TimWolla
Copy link
Member

Follow-up for #18919 and extracted out of #18747.

@nielsdos
Copy link
Member

Right... shift-reduce conflict on argument vs expression...
I'll have a better look tomorrow or so, but on first sight this seems fine. I wonder if it's possible to make it even simpler, but this is already quite simple.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems right to me. Please add a comment to the parser to explain that the reason you do this is to resolve a shift-reduce conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants