Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert ReflectionType::__toString() behavior + deprecate #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic wants to merge 2 commits into from
Closed

Revert ReflectionType::__toString() behavior + deprecate #2137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
289d1ab
Revert ReflectionType::__toString() behavior + deprecate
nikic Sep 21, 2016
93f94b6
Don't mark ReflectionType::__toString() as deprecated for now
nikic Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't mark ReflectionType::__toString() as deprecated for now
  • Loading branch information
@nikic
nikic committed Sep 27, 2016
commit 93f94b63959b4e87a8ff8d626a6c69eac7ca5f89
5 changes: 4 additions & 1 deletion ext/reflection/php_reflection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6701,7 +6701,10 @@ static const zend_function_entry reflection_type_functions[] = {
ZEND_ME(reflection, __clone, arginfo_reflection__void, ZEND_ACC_PRIVATE|ZEND_ACC_FINAL)
ZEND_ME(reflection_type, allowsNull, arginfo_reflection__void, 0)
ZEND_ME(reflection_type, isBuiltin, arginfo_reflection__void, 0)
ZEND_ME(reflection_type, __toString, arginfo_reflection__void, ZEND_ACC_DEPRECATED)
/* ReflectionType::__toString() is deprecated, but we currently do not mark it as such
* due to bad interaction with the PHPUnit error handler and exceptions in __toString().
* See PR2137. */
ZEND_ME(reflection_type, __toString, arginfo_reflection__void, 0)
PHP_FE_END
};

Expand Down
10 changes: 1 addition & 9 deletions ext/reflection/tests/ReflectionNamedType.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,12 @@ var_dump($return->getName());
var_dump((string) $return);

?>
--EXPECTF--
--EXPECT--
string(11) "Traversable"

Deprecated: Function ReflectionType::__toString() is deprecated in %s on line %d
string(11) "Traversable"
string(6) "string"

Deprecated: Function ReflectionType::__toString() is deprecated in %s on line %d
string(6) "string"
string(4) "Test"

Deprecated: Function ReflectionType::__toString() is deprecated in %s on line %d
string(4) "Test"
string(4) "Test"

Deprecated: Function ReflectionType::__toString() is deprecated in %s on line %d
string(4) "Test"
3 changes: 1 addition & 2 deletions ext/reflection/tests/bug72661.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ function test(iterable $arg) { }

var_dump((string)(new ReflectionParameter("test", 0))->getType());
?>
--EXPECTF--
Deprecated: Function ReflectionType::__toString() is deprecated in %s on line %d
--EXPECT--
string(8) "iterable"