FPM: Change last_idle_child lookup to fix idle time computation #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the "last_idle_child" is determined by looking at the starting time, that is, it is the child that has been around for the longest time. A few lines later, for pm = ondemand the idle time is computed for this last_idle_child to decide if it has been idle too long and should be terminated. To make this calculation correct, we need to find the "last_idle_child" by looking at the time of the last request served, not the startup time.
|
@bukka can you take a look at this one please ? |
|
@mpdude, any news? |
|
No, I haven’t done any performance research. I am not even sure how I would do this and what to look out for 🤔 I found this while studying the code and wanted to bring it to the attention of someone who knows better than me 🤷🏻♂️ |
|
@mpdude Are you interested in pursuing this PR? If not, please feel free to close it. Thanks! |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
last_idle_childis determined by looking at the start time. That is, it is the child that has been around for the longest period of time.A few lines later, for
pm = ondemandthe idle time is computed for thislast_idle_childto decide if it should be terminated.Thus, I think we need to determine the
last_idle_childby looking at the time of the last request served, not the startup time.