Unbundle ext/xmlrpc #5640
Closed
Unbundle ext/xmlrpc #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to <https://wiki.php.net/rfc/unbundle_xmlprc> we unbundle ext/xmlrpc.
nikic
approved these changes
May 29, 2020
Contributor
|
Idea: document somewhere how to unbundle an extension from the It'll be easier for reviewers as well, we check if the X files were modified/removed and there we go. |
Member
Author
Well, I just removed the ext/xmlrpc directory, and then grepped for "xmlrpc". Finally, I did a full build, to check whether nothing was broken in the process. |
Member
Author
|
Thanks! Applied as 4fa3687. |
khs1994
added a commit
to khs1994-docker/lnmp
that referenced
this pull request
Jun 4, 2020
Signed-off-by: Kang Huaishuai <[email protected]>
khs1994
added a commit
to khs1994-docker/lnmp
that referenced
this pull request
Jun 4, 2020
Signed-off-by: Kang Huaishuai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://wiki.php.net/rfc/unbundle_xmlprc we unbundle
ext/xmlrpc.