-
Notifications
You must be signed in to change notification settings - Fork 8k
Implementing array_group function #7698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nice feature :) may i recommend for the 4th parameter to be more dynamic:
looking forward seeing this in core |
|
@kaznovac Your first point is a good one, but I am not sure that I got your second one |
645f459 to
04e5982
Compare
|
@cmb69 any clues why does this test case keeps failing? |
|
On AppVeyor, the test causes a segfault. |
04e5982 to
77dadf1
Compare
|
I liked the idea @7snovic! and I think it's a good idea to have it as another function:
|
|
Sorry, but why the 4th parameter is From RFC: Why not, |
77dadf1 to
502787c
Compare
a73ce1e to
9deac57
Compare
|
Since the respective RFC has been declined, I'm closing this ticket. Thanks for your work nonetheless! |
RCF : https://wiki.php.net/rfc/array_column_results_grouping