Enum error message consistency #9350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing magic method tests
…ame in quotes, and updated tests
iluuu1994
reviewed
Aug 16, 2022
|
@ollieread Btw you can add |
kocsismate
reviewed
Aug 21, 2022
| @@ -0,0 +1,15 @@ | |||
| --TEST-- | |||
| Enum __clone | |||
There was a problem hiding this comment.
Nit:
Suggested change
| Enum __clone | |
| Enums cannot include the __clone magic method |
There was a problem hiding this comment.
The rest of the tests could profit from this change
Thanks, and I'm happy to help. As an aside, if you know any other bits that could do with some improvement to consistency, I'm happy to look at them. |
kocsismate
reviewed
Aug 22, 2022
kocsismate
reviewed
Aug 22, 2022
kocsismate
approved these changes
Aug 22, 2022
iluuu1994
reviewed
Aug 22, 2022
iluuu1994
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the points raised in #9262 by doing the following:
Updating magic method exception messages
Previously the error message:
Was only used for:
__sleep__wakeup__set_stateAll of which I believe are "technically" not magic methods, whereas all of the other true magic methods gave the error message:
This PR updates it so that all true magic methods also give the following error:
Normalising double quote usage in error messages
Enum error messages were inconsistent in their usage of double quotes with an enum name, as well as with values.
This PR changes the following error messages:
Properties
Is now
Backing
Is now
In the spirit of keeping this consistent, double quotes have been added to the value when the backing type is int.
Added missing tests
I've also added tests for all of the magic methods that weren't previously covered.
Stringable
Nothing was done with the Stringable interface, as originally planned, because the usage of
__toStringwas always caught before the interface.