Use quotes for PHP version numbers in README #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @osma - I didn't know that was how YAML numbers worked. In fact, I find all YAML config confusing, so I'm glad you made this change as it will help a lot of future developers out. Thanks again. |
|
I find YAML confusing too, and I didn't know about the number parsing either until I found out the hard way - thanks again @ngrie for clarifying this! Thanks for merging! |
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP version numbers in the README did not use quotes. This is fine for e.g. 7.1, 7.2, 7.3 and 7.4 but not 8.0, which is interpreted as 8 by YAML and currently resolves to 8.1.1. See this comment by @ngrie for an explanation.
Fixes #73
(I suppose a similar fix should be made also for other php-actions modules which use the same mechanism, at least php-actions/phpunit)