Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove PHP 8.4.* deprecations#733

Merged
mihaileu merged 1 commit into
php-amqplib:masterfrom
mkoprek:remove_php_84_deprecations
Jan 8, 2025
Merged

Remove PHP 8.4.* deprecations#733
mihaileu merged 1 commit into
php-amqplib:masterfrom
mkoprek:remove_php_84_deprecations

Conversation

@mkoprek
Copy link
Copy Markdown
Contributor

@mkoprek mkoprek commented Jan 3, 2025

Just removing some deprecations messages from newest PHP version

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

@mkoprek mkoprek requested a review from mihaileu as a code owner January 3, 2025 23:05
@mkoprek
Copy link
Copy Markdown
Contributor Author

mkoprek commented Jan 4, 2025

Hey @mihaileu; I see that only linters are being run in the pipelines. Shouldn't we add phpunit execution there as well?

@mihaileu mihaileu merged commit 76ca2c9 into php-amqplib:master Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants