Fix HtmlToDjot definition list conversion #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ': term' format for dt elements (not bare text) - Use indented content for dd elements (2 spaces) - Preserve indentation in cleanup() for definition content - Support multiple dt terms sharing one dd definition - Add test for multiple terms case The previous output was not valid Djot and failed to roundtrip correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
============================================
+ Coverage 93.54% 93.56% +0.02%
- Complexity 1705 1723 +18
============================================
Files 65 65
Lines 4446 4508 +62
============================================
+ Hits 4159 4218 +59
- Misses 287 290 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HtmlToDjot to output valid Djot syntax for definition lists that can roundtrip correctly.
Before (broken)
Converted to:
This is not valid Djot - the term needs
:prefix and definition needs indentation.After (fixed)
This roundtrips correctly back to:
Multiple terms support
Converts to:
Test plan