[Symfony] Try to get env parameter from container before throwing an exception #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue was properly fixed in 0.9 version. Unfortunately, it is not possible to fix it in 0.8 version. |
makasim
reviewed
Oct 26, 2018
| @@ -161,7 +162,11 @@ private function resolveDSN(ContainerBuilder $container, $dsn) | |||
| $matches = []; | |||
| if (preg_match('/%env\((.*?)\)/', $dsn, $matches)) { | |||
| if (false === $realDsn = getenv($matches[1])) { | |||
| throw new \LogicException(sprintf('The env "%s" var is not defined', $matches[1])); | |||
| try { | |||
| $realDsn = $container->getParameter($matches[1]); | |||
There was a problem hiding this comment.
shouldn't it be $dsn instead of $matches[1]
There was a problem hiding this comment.
I'll take a look at it tonight :)
|
@Steveb-p is there any news? |
|
The issue is properly fixed in 0.9 version which is soon to be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regard to an issue raised on gitter.