Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated doc block to be coherent with the suggested PSR #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 27, 2016

This will fix #51

@sagikazarmark
Copy link
Member

LGTM. What about Style CI then?

@Nyholm
Copy link
Member Author

Nyholm commented Jan 27, 2016

StyleCI does not like this doc block. Should I comply with the patch that StyleCI provides? Or do you want to change the config in StyleCI?

@sagikazarmark
Copy link
Member

Good question, have no idea. We could turn off some docblock check, maybe that helps.

@joelwurtz
Copy link
Member

Certainly the align thing in docblock,

@joelwurtz
Copy link
Member

I added this in php style ci config :

disabled:
    - phpdoc_align
    - phpdoc_separation

Then it was ok, bug is coming from separation but if we only remove this, then align has another bug :/

@joelwurtz
Copy link
Member

I think for the moment we should add the blank line proposed by the fixer, it's not a big problem, and we can try to do a PR on php-cs-fixer (at least an issue)

@sagikazarmark
Copy link
Member

Ok, let's not add those disable statements then. I agree we can live with that extra line.

@dbu
Copy link
Contributor

dbu commented Jan 28, 2016

👍

@Nyholm
Copy link
Member Author

Nyholm commented Jan 28, 2016

Updated

joelwurtz added a commit that referenced this pull request Jan 28, 2016
Updated doc block to be coherent with the suggested PSR
@joelwurtz joelwurtz merged commit 79ff0b8 into php-http:master Jan 28, 2016
@Nyholm Nyholm deleted the doc_block branch January 28, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new doc block for documenting array values
4 participants