Remove roadrunner specific session handling #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we update this PR now when symfony/symfony#41390 is merged? |
06d6ee0 to
60d4d71
Compare
e3a9d9e to
964e132
Compare
d2dd6b0 to
372a812
Compare
|
@Nyholm rebased and updated the dependencies. |
Nyholm
reviewed
Sep 6, 2021
| { | ||
| $this->kernel = $kernel; | ||
| $this->psrFactory = new Psr7\Factory\Psr17Factory(); | ||
| $this->httpFoundationFactory = $httpFoundationFactory ?? new HttpFoundationFactory(); | ||
| $this->httpMessageFactory = $httpMessageFactory ?? new PsrHttpFactory($this->psrFactory, $this->psrFactory, $this->psrFactory, $this->psrFactory); | ||
|
|
||
| if ($kernel instanceof HttpCache) { |
There was a problem hiding this comment.
if ($kernel instanceof HttpCache) { was only needed to get the parameters from the wrapped kernel. As we are not longer need to handle the sessions here we could remove this. The support for HttpCache is still here as HttpCache implements HttpKernelInterface and will handle the requests as expected.
Did update the tests which create the Runner instances.
piku235
pushed a commit
to piku235/runtime
that referenced
this pull request
Oct 5, 2021
* Fix removing of session cookie after logout * Remove roadrunner specific session handling * Simplify also the Runner * Remove session reset * Fix php-cs * Increased required versions * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is build on top of the following refractoring: symfony/symfony#41390
Fixes:
TODO: