Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add disabled item functionality#40

Merged
mikeymike merged 5 commits into
masterfrom
feature/disable-items
Oct 3, 2016
Merged

Add disabled item functionality#40
mikeymike merged 5 commits into
masterfrom
feature/disable-items

Conversation

@mikeymike

Copy link
Copy Markdown
Member

No description provided.


/**
* @var bool
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a default value

Comment thread src/MenuStyle.php Outdated
* @param TerminalInterface $terminal
* @throws InvalidInstantiationException
*/
// TODO: Disabled marker ideally without breaking change.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@codecov-io

codecov-io commented Sep 30, 2016

Copy link
Copy Markdown

Current coverage is 69.13% (diff: 64.51%)

Merging #40 into master will decrease coverage by 0.72%

@@             master        #40   diff @@
==========================================
  Files            15         15          
  Lines           574        593    +19   
  Methods         149        153     +4   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            401        410     +9   
- Misses          173        183    +10   
  Partials          0          0          

Powered by Codecov. Last update a6989b8...a02ca7f

@mikeymike mikeymike force-pushed the feature/disable-items branch from b7d3ca7 to 84ed66c Compare October 3, 2016 17:33
@mikeymike mikeymike force-pushed the feature/disable-items branch from c5225e6 to f61d122 Compare October 3, 2016 18:02
@mikeymike

Copy link
Copy Markdown
Member Author

@AydinHassan Updated dude... Just grabbing some food then I'll release a new version 👍

@AydinHassan

Copy link
Copy Markdown
Member

LGTM @mikeymike, merge and tag away when you're ready

@mikeymike mikeymike merged commit c7bdb1b into master Oct 3, 2016
@mikeymike mikeymike deleted the feature/disable-items branch October 3, 2016 18:37
@AydinHassan

Copy link
Copy Markdown
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants