Minor modification to support removeModifier in SpanParser - #231
Open
williameggers wants to merge 1 commit into
Open
Minor modification to support removeModifier in SpanParser#231williameggers wants to merge 1 commit into
williameggers wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor change adds support for removing style modifiers in the options attribute by prefixing them with a tilde (~).
With this change, you can now explicitly remove a modifier by writing something like ~italic, which makes it easier to override modifiers in nested tag situations when required.
The implementation just checks if an option starts with ~, and if so, strips that off and removes the corresponding modifier from the style instead of adding it.
That said, I'm not totally sure if you're happy with the use of ~ for this. If you’d prefer a different character (like -), or even a separate attribute for removed modifiers, I’m totally open to changing the approach based on your preference!