Strict mode allows recording new cassettes#229
Open
snelg wants to merge 10 commits intophp-vcr:masterfrom
Open
Strict mode allows recording new cassettes#229snelg wants to merge 10 commits intophp-vcr:masterfrom
snelg wants to merge 10 commits intophp-vcr:masterfrom
Conversation
The parsing/serializing causes nothing to be sent without this change.
… strict-mode-fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is an addition to #228
I think that "strict" mode should behave like "once" mode when the requested cassette does not exist.
The original "strict" implementation has no way to record initial cassettes.
When I need a new cassette (e.g. I create a new TestCase), I have to change my code to
setMode('once'), create the cassette, and then change my code back tosetMode('strict').I'm submitting this as a separate pull request, because #228 was supposed to be only a style-cleaned version of the original #160. This is a functional change from that PR.
What has been done
How to test
setMode('strict')Todo
Notes