Closed
Conversation
|
@renatomefi ping? :) |
|
Any ideas if this will be merged? |
I guess the one of good solutions is body response matcher|filter|ignore_keywords, or disable third party libs to track by VCR... Maybe middlewares? |
Contributor
|
Since we're persisting the whole curl info array starting with #300 this should be redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
@hannesl and I encountered this issue #227. @hannesl's solution was to change elasticsearch codebase. However, I thought it is best to add the change to php-vcr.
What has been done
How to test