Never validate curl post settings for non post requests#273
Open
Toflar wants to merge 1 commit intophp-vcr:masterfrom
Open
Never validate curl post settings for non post requests#273Toflar wants to merge 1 commit intophp-vcr:masterfrom
Toflar wants to merge 1 commit intophp-vcr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After my latest dependency update I suddenly get
To set a CURLOPT_READFUNCTION, CURLOPT_INFILESIZE must be set.exceptions even though I send aGETrequest.Something must have changed here but I guess it's just save to always early return if the request is not a
POSTrequest anyway because that's essentially what the method is for 😄