Added 'strict' mode which requires all requests to play in order.#276
Open
mpatnode wants to merge 3 commits intophp-vcr:masterfrom
Open
Added 'strict' mode which requires all requests to play in order.#276mpatnode wants to merge 3 commits intophp-vcr:masterfrom
mpatnode wants to merge 3 commits intophp-vcr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a refresh of #160. I removed the SOAPAction specific change since it was not material to this fix. For tests which issue multiple requests, this resulted in a huge performance benefit to not have to search the entire yml object on every request.
What has been done
Adds a strict mode which only replays requests in order and throws an exception if all requests are not played.
How to test
Add
to your code. Watch your tests run faster.
Todo