Fix: Notice Trying to access array offset on value of type null when …#301
Closed
bwood wants to merge 1 commit intophp-vcr:masterfrom
Closed
Fix: Notice Trying to access array offset on value of type null when …#301bwood wants to merge 1 commit intophp-vcr:masterfrom
bwood wants to merge 1 commit intophp-vcr:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
This has been resolved @JeroenVanOort's commit: 198dfb2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…using PHP 7.4.
Context
Ensure that variable is an array. PHP 7.4 is less forgiving about this than earlier versions of PHP. New fixtures can result in a
$recordingvalue of NULL. When this happens PHP 7.4 emits a notice. The notice appears in the output of functions under test by Behat and cause failures.What has been done
Add a conditional testing that $recording is an array with at least one element.
How to test
Without this modification, create a new recording file (aka fixture) and attempt to play it back. Use PHP 7.4.