Open
Conversation
|
Can we get eyes on this? This is an absolute must for security and a blocker before we could use it on our projects. |
|
@aksonnic I added your changes to my own fork, as I also needed a fix for a small curl bug. Can you give me an example of how to use it? I see you added tests, but there you create your own Cassettes. Is that the only way? Is this no compatibly with the "default" use of VCR\VCR::turnOn();
VCR\VCR::insertCassette('some_name.yml');
/** The tested code **/
VCR::eject();
VCR::turnOff();Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Typically there are lots of private values in network request/response that should not be saved to storage, and potentially be committed as part of a cassette. This PR allows users to specify redactions to be applied before/after storage. In all other respects the library works as it did before.
What has been done
How to test
Notes
scrub($request, $response)andunscrub($recording). It's like that because each direction instantiatesRequestorResponseobjects at different times, and was an attempt to prevent needless array<->object conversions, but maybe it's not worth bothering.Scrubber/scrub/unscrubperhaps isn't the best naming