FIX: Add handling for array values in response headers#401
Open
SlimDeluxe wants to merge 1 commit intophp-vcr:masterfrom
Open
FIX: Add handling for array values in response headers#401SlimDeluxe wants to merge 1 commit intophp-vcr:masterfrom
SlimDeluxe wants to merge 1 commit intophp-vcr:masterfrom
Conversation
Two new tests have been added to confirm that arrays as values in headers are properly handled. Changes in the Response class ensure that the getContentType and getHeader methods correctly handle header values that are arrays, by returning either the first element of the array (for the getContentType method) or the entire array (for the getHeader method).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The problem exists with servers that return duplicate headers. It's true that they should fix their own stuff, but it's also of interest that this package is resilient to such edge cases that appear in production.
What has been done
Response.phpso that array as a value for any header is handled without errors.Response::getContentTypestill works if Content-Type is received as an array. It returns the first value of the array.How to test
composer test