Document how to use with GitHub Actions#3695
Open
fulldecent wants to merge 1 commit intophpDocumentor:masterfrom
Open
Document how to use with GitHub Actions#3695fulldecent wants to merge 1 commit intophpDocumentor:masterfrom
fulldecent wants to merge 1 commit intophpDocumentor:masterfrom
Conversation
jaapio
requested changes
Apr 10, 2024
Member
jaapio
left a comment
There was a problem hiding this comment.
Thanks for creating this part of the docs. It's really nice that you are adding fixes for the docs. It would be nice if you could check the github action, I think this helps to make the workflow easier.
Comment on lines
+74
to
+75
| - name: Build with phpDocumentor | ||
| run: php -d xdebug.mode=off ${{ github.workspace }}/tools/phpDocumentor run -vv -d source --target docs --cache-folder phpdoc-cache --template default |
Member
There was a problem hiding this comment.
phpDocumentor provides a github action from this repository: https://github.com/phpDocumentor/phpDocumentor/blob/master/action.yml
- name: "Build"
uses: "phpDocumentor/phpDocumentor@master"
with:
target: "build/docs"
I think this is a better way of running since we can pack every dependency we need in a docker image. So people do not have to care about installing php correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2242