Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor fix: Import Attribute symbol in Format and RetryThreshold Attributes #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2023
Merged

Minor fix: Import Attribute symbol in Format and RetryThreshold Attributes #1075

merged 2 commits into from
Dec 28, 2023

Conversation

gsteel
Copy link
Contributor

@gsteel gsteel commented Dec 28, 2023

No description provided.

@dantleech
Copy link
Member

oops, was this not working ?!

@gsteel
Copy link
Contributor Author

gsteel commented Dec 28, 2023

It works fine @dantleech, but if you're using Psalm/PHPStan, they complain that the attributes aren't attributes!

@dantleech
Copy link
Member

somehow some CS issues need fixing

@dantleech dantleech enabled auto-merge (squash) December 28, 2023 18:12
@dantleech dantleech disabled auto-merge December 28, 2023 18:12
@dantleech dantleech merged commit bde83dc into phpbench:master Dec 28, 2023
@dantleech
Copy link
Member

Thanks!

@gsteel gsteel deleted the use-attribute branch December 28, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @dantleech