Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 9, 2024. It is now read-only.

Use WixPSExtension to install PowerShell extension#44

Merged
lextm merged 3 commits intophpmanager:masterfrom
messageconcept:pssnapin
Apr 16, 2021
Merged

Use WixPSExtension to install PowerShell extension#44
lextm merged 3 commits intophpmanager:masterfrom
messageconcept:pssnapin

Conversation

@mbiebl
Copy link
Contributor

@mbiebl mbiebl commented Mar 31, 2021

Instead of using a managed custom action and InstallUtil.exe, we vastly
simplify the installation using WixPSExtension.

Fixes: #33

@mbiebl
Copy link
Contributor Author

mbiebl commented Mar 31, 2021

I have an alternative approach in messageconcept@dcd0f6c

Not sure which one you prefer. The Module based approach is more modern and generally the recommended method nowadays.

Let me know what you think.

@mbiebl
Copy link
Contributor Author

mbiebl commented Mar 31, 2021

There are unrelated white space changes in this PR. So #43 should probably be merged first and I'll rebase this PR.

@lextm
Copy link
Member

lextm commented Mar 31, 2021

For a legacy project, I really try to avoid huge pull requests like #43 which introduces nothing but source code format changes.

If possible, undo unnecessary line changes in this pull request.

@mbiebl
Copy link
Contributor Author

mbiebl commented Mar 31, 2021

If possible, undo unnecessary line changes in this pull request.

Those are done automatically by Visual Studio. I can undo them manually, but this is kinda annoying having to do that every time I touch the file.
If you don't want to merge #43, would you be ok, if commits contain white space fixes for files that are touched by a PR?

@mbiebl
Copy link
Contributor Author

mbiebl commented Mar 31, 2021

Anyway, will redo this commit to drop unnecessary white space changes. Feel free to close #43

If you'd prefer the Modules based approach over fixing the Snapin one, please let me know

mbiebl added 2 commits March 31, 2021 22:53
Instead of using a managed custom action and InstallUtil.exe, we vastly
simplify the installation using WixPSExtension.

Fixes: phpmanager#33
We support IIS 7 and above. Instead of explicitly mentioning any version
at all, just drop it, as IIS 6 is no longer really relevant.
@mbiebl
Copy link
Contributor Author

mbiebl commented Mar 31, 2021

Force-Pushed with unnecessary white space changes removed.

Please have another look

It makes more sense to group it together with the PowerShell assembly
then with the license file.
@lextm lextm merged commit 70e4709 into phpmanager:master Apr 16, 2021
@mbiebl mbiebl mentioned this pull request Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Add-PsSnapin PHPManagerSnapin

2 participants