Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert top menu to Bootstrap's navbar component #15775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauricioFauth merged 3 commits into from
Jan 17, 2020
Merged

Convert top menu to Bootstrap's navbar component #15775

MauricioFauth merged 3 commits into from
Jan 17, 2020

Conversation

@MauricioFauth
Copy link
Member

@MauricioFauth MauricioFauth commented Jan 11, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2020 •
edited
Loading

Codecov Report

Merging #15775 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15775      +/-   ##
============================================
+ Coverage     52.92%   52.98%   +0.06%     
+ Complexity    14885    14877       -8     
============================================
  Files           462      462              
  Lines         60967    60954      -13     
============================================
+ Hits          32266    32296      +30     
+ Misses        28701    28658      -43

@williamdes williamdes added this to the 5.1.0 milestone Jan 11, 2020
@williamdes williamdes added the UI Issues relating to the user interface label Jan 11, 2020
@williamdes
Copy link
Member

williamdes commented Jan 11, 2020

@sudo-bot deploy PR

@sudo-robot
Copy link

sudo-robot commented Jan 11, 2020 •
edited
Loading

Deployed (phpmyadmin-pr-15775): bootstrap-navbar commit: dc861be1ae6dc7db018177b16452cf57e41e34df

url: https://phpmyadmin-pr-15775.wdes.eu.org
user: public
user: public

Deploy finished

williamdes
williamdes approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I know this is a draft but on small screen the tabs are hidden

@MauricioFauth
Copy link
Member Author

MauricioFauth commented Jan 11, 2020

I know this is a draft but on small screen the tabs are hidden

There is a hidden button on the left side that toggles the menu. Also the 'more' dropdown still not works.

@MauricioFauth MauricioFauth force-pushed the bootstrap-navbar branch 5 times, most recently from cd34d49 to 17166ab Compare January 12, 2020 22:11
@MauricioFauth MauricioFauth marked this pull request as ready for review January 12, 2020 22:11
@williamdes
Copy link
Member

williamdes commented Jan 12, 2020

@sudo-bot /deploy PR

@sudo-robot
Copy link

sudo-robot commented Jan 12, 2020 •
edited
Loading

Deployed (phpmyadmin-pr-15775): bootstrap-navbar commit: a4f2ef2059380ce606bed55686322a89a82d07b8

url: https://phpmyadmin-pr-15775.wdes.eu.org
user: public
user: public

Deploy finished

williamdes
williamdes approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Usually the menu "burger" button is on the right
Can you make the bars black ?

@williamdes
Copy link
Member

williamdes commented Jan 12, 2020

Can you please fix the effect ?
screencast-phpmyadmin-pr-15775 wdes eu org-2020 01

@MauricioFauth
Convert top menu to Bootstrap's navbar component
ac8ecb7 
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth
Remove topmenu custom CSS
f3bfd0b 
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth
Fix menu resizer for topmenu navbar
f24cedd 
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth
Copy link
Member Author

MauricioFauth commented Jan 17, 2020

Usually the menu "burger" button is on the right
Can you make the bars black ?

The toggle button is left aligned by default and the icon is using the same color as the links also by default.

Can you please fix the effect ?

I disabled the transitions altogether. I don't know what is causing this. I need to investigate it further.

@MauricioFauth MauricioFauth merged commit fc8396f into phpmyadmin:master Jan 17, 2020
@MauricioFauth MauricioFauth deleted the bootstrap-navbar branch January 17, 2020 18:26
@williamdes williamdes mentioned this pull request Jan 24, 2020
Closed
@williamdes
Copy link
Member

williamdes commented Jan 24, 2020

Closes: #14183

@williamdes williamdes added the Enhancement A feature request for improving phpMyAdmin label Jan 24, 2020
This was referenced Nov 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

No one assigned

Labels

Enhancement A feature request for improving phpMyAdmin UI Issues relating to the user interface

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MauricioFauth @williamdes @sudo-robot