Fix #17713 - Show clear error when SQL setup files are missing#20294
Open
predictor2718 wants to merge 1 commit into
Open
Fix #17713 - Show clear error when SQL setup files are missing#20294predictor2718 wants to merge 1 commit into
predictor2718 wants to merge 1 commit into
Conversation
Signed-off-by: Nicolai Ehrhardt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17713 (parallel of #20293 for master/6.0-dev — same fix at the new file paths).
When the user removes the
resources/sql/directory (per FAQ 1.44 to reduceinstalled size on disk) and then clicks "Create" on the configuration-storage
prompt,
Relation::getCreateTableSqlQueries()returns an empty array(
file_get_contentsfails).Relation::fixPmaTables()then accessed$createQueries[$table]which was undefined, ending up withtryQuery(null, ...)—TypeError, HTTP 500.This patch:
file_get_contentswarning when the SQL file is missing (theresources/sql/directory is intentionally removable per FAQ).fixPmaTables()and sets a clear messagepointing the user at the missing directory, instead of crashing.
Verified end-to-end against MySQL 8 — clicking "Create" with the
resources/sql/directory removed now shows"Cannot create the phpMyAdmin configuration storage: the SQL setup files in
/…/resources/sql/ are missing. Please restore the directory from the
phpMyAdmin distribution." instead of an "Internal error: TypeError".
Error message after the fix: