Fix #20198 - Show bookmarks with blank database in any database#20306
Open
eyupcanakman wants to merge 1 commit into
Open
Fix #20198 - Show bookmarks with blank database in any database#20306eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
…base Bookmark::getList() and Bookmark::get() filter by AND dbase = '<db>', so a bookmark stored with dbase = '' is hidden once a current database is selected. Mirror the existing user = '' fallback with AND ( dbase = '' OR dbase = '<db>' ) in both methods. Signed-off-by: Eyüp Can Akman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bookmark::getList()andBookmark::get()filter byAND dbase = '<db>', so a bookmark stored withdbase = ''is hidden once a current database is selected. The user clause already has a matching blank fallback (( user = '' OR user = '<user>' )). The dbase clause now mirrors it:( dbase = '' OR dbase = '<db>' ).Note: in
Sql::storeTheQueryAsBookmark, the "replace existing bookmark" path now also matches a same-labeled shared (blank-database) bookmark when saving from a current database. Happy to scope that down if it's unwanted.Fixes #20198.