Create the StatementInfo class#550
Merged
MauricioFauth merged 3 commits intophpmyadmin:masterfrom Feb 5, 2024
Merged
Conversation
It replaces the string value of the querytype field of the statement flags. Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
============================================
- Coverage 96.54% 96.54% -0.01%
Complexity 2149 2149
============================================
Files 86 87 +1
Lines 5006 5004 -2
============================================
- Hits 4833 4831 -2
Misses 173 173 ☔ View full report in Codecov by Sentry. |
kamil-tekiela
approved these changes
Feb 4, 2024
Contributor
kamil-tekiela
left a comment
There was a problem hiding this comment.
I love it! Great job!
williamdes
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
StatementInfoclass from the phpMyAdmin's source code into the sql-parser's code.