Issue #1523#1531
Merged
Merged
Conversation
Member
|
This seems fine, but we should probably try to give people a head's up about it: |
Member
Author
|
@michael-grunder what if we will add server address to all exceptions and add the notice to documentation that all exceptions ware changed? |
Member
Author
|
Also there may be different code for every exception (now zero is everywhere) so users will not need to compare exception messages. |
Member
|
Yeah unique error codes are probably useful too. We're allowed to break things for 5.0.0 but if we can let downstream users know they'd probably appreciate it. On the other hand they might just completely ignore any warnings until they upgrade and then come yell at us. 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add server address to exception message.