Thanks to visit codestin.com
Credit goes to github.com

Skip to content

.deb related fixes #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2012
Merged

.deb related fixes #156

merged 1 commit into from
Apr 3, 2012

Conversation

Bergstein
Copy link
Contributor

Correct .deb filename (last git-tag name used as version number).
Unified php5/conf.d support (now usable with php5-fpm).

Unified php5/conf.d support.
@nicolasff
Copy link
Member

Hello Dmitry,

What is the aim of this pull request? It looks like mkdeb-apache2.sh, except without the compatibility code for Ubuntu vs Debian and none of the Apache files.

Thanks

@Bergstein
Copy link
Contributor Author

First. Standards compliance:
«The Debian binary package file names conform to the following convention: -.deb»

Second.
AFAIK, best practice is using symlinks like «/etc/php5/conf.d -> /etc/php5/$SAPI/conf.d». ($SAPI - apache2, fpm or cli.)
So, /etc/php5/conf.d/redis.ini will be usable for all systems.
For example, see structure of php5-fpm package.

PS. Sorry, non native english speaker.

@georgekola
Copy link

the .deb built using this and installed works fine on ubuntu 12.04 with php5.3.10. The .deb built with mkdeb-apache2.sh does not work properly.

@nicolasff
Copy link
Member

@breathless thanks for your contribution and @georgekola thanks for your input.

nicolasff added a commit that referenced this pull request Apr 3, 2012
@nicolasff nicolasff merged commit e1a65fd into phpredis:master Apr 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants