Fixed crash with clone of Redis object #1789
Conversation
|
@michael-grunder @yatsukhnenko Hi guys anyway we can get this into next release. The last issue with auth was resolved. I see one test failing, but seems completely unrelated to the changes and only on 1 clang environment. |
|
@michael-grunder / @yatsukhnenko Can we please revisit this PR, if there are any concerns I am happy to address them or adjust code as needed, but hoping we could get this in to the next release. |
|
Hi @iliaal. I'm putting together the 5.3.3 release right now, which just includes two tiny changes for PHP8 compatibility. I think fixing the segmentation fault on clone is a good idea but would want to hold off on a full clone implementation until a subsequent release where we have release candidates. |
|
@michael-grunder heh I saw 5.3.3 came out, can we consider this for 5.3.4? |
|
Sure, I'm OK with that. I want to make sure we don't worsen the situation with connection re-use (e.g. going out of sync) but being able to |
Current clone of redis object results in a crash. This patch fixes the crash and allows a copy of redis object to be created. This is helpful when you want to share same connection but with different settings (i.e. different OPT_PREFIX)