Socket Retrieval #18
Closed
Socket Retrieval #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty, this make socket resolution 15-20% faster. Fixed some compiler warnings
|
Curious here - any reason why this was not merged? |
|
No idea :-) Ilia
|
Closed
|
Anything wrong with this patch? |
|
Not as far as I know On Wed, Jun 13, 2012 at 12:56 PM, Lars Strojny
|
Closed
|
Reimplemented in 8fa85af |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the code to store the socket information inside the object struct. This allows code to avoid 2 hash lookups on every function (1 lookup of object property and another to lookup the socket in the resource list). This makes this specific operation 15-20% faster.
There are also a few compiler warning fixes.