Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update rpm packer for phpredis#1904

Merged
michael-grunder merged 1 commit into
phpredis:developfrom
JGodin-C2C:develop
Jan 15, 2021
Merged

Update rpm packer for phpredis#1904
michael-grunder merged 1 commit into
phpredis:developfrom
JGodin-C2C:develop

Conversation

@JGodin-C2C

Copy link
Copy Markdown
Contributor

What:

This PR update the RPM packaging process. It uses now docker and the latest version of phpredis (5.3.0).

Why:

The RPM packaging was from 2014. It needed to be refreshed.

@remicollet

remicollet commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

Sorry, but I don't think it make sense to maintain a spec file here.

Indeed this one is really outdated.

Your proposal is really not enough (missing optional dependency, compression libraries and extensions)

Better maintained in the RPM distribution itself.
https://src.fedoraproject.org/rpms/php-pecl-redis5/tree/master

Especially as binary packages are also produced there and available for

IMHO, simply remove this "rpm" directory.

@JGodin-C2C

Copy link
Copy Markdown
Contributor Author

Hey Remi, thanks for taking the time to answer me.

You are making a lot of good points here. I actually did not found the rspec that you had linked here before, thank you.

I was trying to understand the problem RHEL8 actually have ( As it is my need ). I found your conversation about this elsewhere but could not understand the problem, i thus took the initiative to build my own packages and update this at it was , well, old.

I think deleting this directory could be the right thing to do. I, however, prefer the 'moved here' solution.

@remicollet

Copy link
Copy Markdown
Collaborator

I was trying to understand the problem RHEL8 actually have

Should read links in https://rpms.remirepo.net/temp/epel-temp.repo
Especially https://pagure.io/epel/issue/75 and linked other issues

@remicollet remicollet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple README.md LGTM.

@JGodin-C2C

Copy link
Copy Markdown
Contributor Author

Yup, i found it in the previous comment. Thanks for the head up. This does not sound good for the future of EPEL/PHP combo ...

@michael-grunder michael-grunder merged commit 69e1a1b into phpredis:develop Jan 15, 2021
@michael-grunder

Copy link
Copy Markdown
Member

Merged, thanks!

michael-grunder pushed a commit that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants