Added support for remapping the cluster's keyspace on a failover#2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using phpredis with RedisCluster, and a failover takes place on the cluster, the old primary does not get removed from the masters cache.
It means that if a user attempts to ping the masters after a failover, an exception will be thrown.
This PR adds support for remapping the cluster's keyspace when a failover occurs:
In the current implementation, when we get a MOVED error, we check to see if the redirected address belongs to an existing primary, and if it doesn't, we create a new node and add it to the cluster's primaries. It will end up with a stale primary on the _masters array.
In this fix, I added a check to detect a failover: if the redirected node was a replica of the master that is currently pointing to this slot, then a failover had occurred. In the case of a failover, the cluster's topology has changed, and we will call cluster_map_keyspace() to reinitialize the cluster's nodes cache.
I ran the following test scenario:
Output:
With the changes I suggest in this PR the _masters array is updated correctly after the failover: