RedisCluster stub fixes#2183
Merged
Merged
Conversation
I can now run RedisCluster unit tests within a PHP build tree build in debug mode without any deprecation warnings or arginfo/zpp errors.
9b716aa to
4470313
Compare
Contributor
|
mixed just cannot be used with anything else, the engine enforces it.
|
Member
Author
|
Ahh, I understand now. It's that It's weird that this doesn't throw a fatal error for me when I run our unit tests. Perhaps |
Member
Author
|
@yatsukhnenko Since this was almost entirely changes in PHP I figured it was safe to just merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can now run RedisCluster unit tests within a PHP build tree build in debug mode without any deprecation warnings or arginfo/zpp errors.