Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix remaining compiler warning. #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 31, 2012
Merged

Fix remaining compiler warning. #240

merged 17 commits into from
Aug 31, 2012

Conversation

remicollet
Copy link
Collaborator

With this, redis build with -Wall option.

Please review 1defd42 (ce is never initialized, so I think redis_ce is the correct value)

Some are false positive, I could check the logic where compiler could not.

Some could introduce race condition (ex if callback_type is 1 or 2 by lack of luck...)

I know these are only warning... but I really like build without any warnings ;)

@remicollet
fix warning: variable 'redis_inst' set but not used [-Wunused-but-set…
e3b2a46 
…-variable]
@remicollet
warning: variable 'redis_inst' set but not used (compiler can't check…
83053ea 
… logic here)
@remicollet
redis.c:2350:17: warning: variable 'type' set but not used
0d725ed
@remicollet
redis.c:2394:7: warning: variable 'nb_keys' set but not used
297d83e
@remicollet
redis.c:2273:11: warning: variable 'object' set but not used
518599f
@remicollet
redis.c:2699:25: warning: variable 'type' set but not used
fa9bfeb
@remicollet
redis.c:4652:13: warning: variable 'type' set but not used
fa28264
@remicollet
redis.c:4650:23: warning: variable 'hval_len' set but not used
eccffe5
@remicollet
redis.c:5414:23: warning: 'ce' may be used uninitialized in this func…
1defd42 
…tion (please REVIEW this one)
@remicollet
redis.c:5413:23: warning: 'z_fun' may be used uninitialized in this f…
31b3840 
…unction
@remicollet
redis.c:5412:3: warning: 'callback_type', 'callback_ft_name_len', 'ca…
2c907f2 
…llback_ft_name' may be used uninitialized in this function
@remicollet
redis.c:2388:26: warning: 'timeout' may be used uninitialized in this…
bdc5336 
… function
@remicollet
redis.c:4300:33: warning: 'arr_weights_hash' may be used uninitialize…
bad9073 
…d in this function
@remicollet
redis.c:3508:21: warning: 'p', 'cmd' may be used uninitialized in thi…
1cd7baa 
…s function
@remicollet
fix test report (backtrace index)
d4bdb35
@remicollet
fix php warning during tests
ac09cec
@remicollet
proposal for multi-version test suite ("All tests passed." with 2.6.0…
2516eb2 
…RC6)
@remicollet
Copy link
Collaborator Author

Latest commit is a proposal for a test suite aware of API change between server version.

$ redis-cli -v
redis-cli 2.5.12
$ php TestRedis.php 
Note: these tests might take up to a minute. Don't worry :-)
..............................................................................
All tests passed.

If you think this is a nice solution which meet your need, I will work on adding more conditions to have a working test suite with older version (probably 2.4.10 which is current version in fedora 17 and EPEL)

@nicolasff
Copy link
Member

Thanks for fixing the test backtrace as well! All of this looks good.

nicolasff added a commit that referenced this pull request Aug 31, 2012
@nicolasff
Merge pull request #240 from remicollet/master
28fe4c1 
Fix remaining compiler warning.
@nicolasff nicolasff merged commit 28fe4c1 into phpredis:master Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @nicolasff